[Arch] email_service.py, notifiers/webhook.py, middleware.py are essentially untested #66

New issue

Closed

opened 2026-07-01 07:27:19 +02:00 by bullitt · 1 comment

bullitt commented

2026-07-01 07:27:19 +02:00

Owner

Severity: Medium | Category: Testing

email_service.py — 37% coverage, no dedicated test file. notifiers/webhook.py — no test file at all (unlike mqtt/ntfy which both have one). middleware.py (AccessLogMiddleware) — 0% coverage.

Recommendation: Add test_email_service.py (mock SMTP), test_webhook_notifier.py (mirror the test_mqtt.py/test_ntfy_notifier.py pattern with respx), and test_middleware.py.

Full detail: docs/architecture-review.md § C, Finding "email_service.py, notifiers/webhook.py, and middleware.py..."

**Severity:** Medium | **Category:** Testing `email_service.py` — 37% coverage, no dedicated test file. `notifiers/webhook.py` — no test file at all (unlike mqtt/ntfy which both have one). `middleware.py` (`AccessLogMiddleware`) — 0% coverage. **Recommendation:** Add `test_email_service.py` (mock SMTP), `test_webhook_notifier.py` (mirror the `test_mqtt.py`/`test_ntfy_notifier.py` pattern with `respx`), and `test_middleware.py`. Full detail: `docs/architecture-review.md` § C, Finding "email_service.py, notifiers/webhook.py, and middleware.py..."

bullitt added the

arch

label

2026-07-01 07:27:55 +02:00

bullitt commented

2026-07-01 08:43:46 +02:00

Author

Owner

Fixed on branch architecture-rework, commit ca4161e: added tests/test_email_service.py, tests/test_webhook_notifier.py, tests/test_middleware.py. All three modules now at 100% line coverage (up from 37%/64%/0%). Full suite: 276 passed.

Fixed on branch `architecture-rework`, commit ca4161e: added `tests/test_email_service.py`, `tests/test_webhook_notifier.py`, `tests/test_middleware.py`. All three modules now at 100% line coverage (up from 37%/64%/0%). Full suite: 276 passed.

bullitt closed this issue

2026-07-01 08:44:02 +02:00

bullitt referenced this issue from a commit

2026-07-01 09:15:22 +02:00

test: add tests for email_service.py, notifiers/webhook.py, middleware.py (fixes #66)