[Arch] Stale architecture-enforcement tests are silent no-ops #64
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: High | Category: Testing
tests/test_arch.py:55-84(test_scrapers_obey_dependency_rules,test_all_scrapers_documented) globsscrapers/*.py, but real carrier code moved topacks/*/scraper*.py. The glob matches zero files, so both checks trivially pass without checking anything — CI has been green on a disarmed guard.Recommendation: Update both tests to glob
packs/*/scraper*.py(excluding_template/).Refactoring safety: Deliberately add a forbidden import to a scratch pack file locally, confirm the test fails, then revert.
Full detail:
docs/architecture-review.md§ C + § H.1Fixed on branch
architecture-rework, commit933e290:test_scrapers_obey_dependency_rules/test_all_scrapers_documentednow globpacks/*/scraper*.pyinstead of the now-emptyscrapers/*.py. Verified live by temporarily injecting a forbiddenimport dbinto a pack scraper and confirming the test fails, then reverting.