[Arch] Anemic domain model (informational — no action needed now) #58

Closed
opened 2026-07-01 07:26:52 +02:00 by bullitt · 1 comment
Owner

Severity: Low | Category: Domain

No Shipment/Event/Parser classes exist; db._row_to_dict converts every row to a plain dict; state-machine/enrichment logic operates on dicts via free functions in ingest.py.

Recommendation: No action needed now — consistent, well-documented, well-tested at current complexity. Revisit only if a second comparably complex state machine emerges.

Full detail: docs/architecture-review.md § C, Finding "Anemic domain model" and § G

**Severity:** Low | **Category:** Domain No `Shipment`/`Event`/`Parser` classes exist; `db._row_to_dict` converts every row to a plain dict; state-machine/enrichment logic operates on dicts via free functions in `ingest.py`. **Recommendation:** No action needed now — consistent, well-documented, well-tested at current complexity. Revisit only if a second comparably complex state machine emerges. Full detail: `docs/architecture-review.md` § C, Finding "Anemic domain model" and § G
Author
Owner

Closing without a code change. This finding was explicitly informational in docs/architecture-review.md: "No action needed now — consistent, well-documented, well-tested at current complexity. Revisit only if a second comparably complex state machine emerges." All other actionable findings from the review have now been implemented on architecture-rework; re-open if a second state machine of comparable complexity to the shipment state machine appears and this becomes worth revisiting.

Closing without a code change. This finding was explicitly informational in `docs/architecture-review.md`: "No action needed now — consistent, well-documented, well-tested at current complexity. Revisit only if a second comparably complex state machine emerges." All other actionable findings from the review have now been implemented on `architecture-rework`; re-open if a second state machine of comparable complexity to the shipment state machine appears and this becomes worth revisiting.
Sign in to join this conversation.
No labels
arch
harness
security
ux
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bullitt/trackbox#58
No description provided.