[Arch] Route handler bypasses db.py with raw SQL #56

New issue

Closed

opened 2026-07-01 07:26:46 +02:00 by bullitt · 1 comment

bullitt commented

2026-07-01 07:26:46 +02:00

Owner

Severity: Medium | Category: Architecture

main.py:935-952 (api_bulk_archive_delivered) executes raw SQL directly instead of calling a db.py function, violating docs/architecture.md golden principle #1 ("All DB access through db.py functions").

Recommendation: Move the bulk-archive query into db.py as db.bulk_archive_delivered(shipment_ids).

Full detail: docs/architecture-review.md § C, Finding "Route handler bypasses db.py with raw SQL"

**Severity:** Medium | **Category:** Architecture `main.py:935-952` (`api_bulk_archive_delivered`) executes raw SQL directly instead of calling a `db.py` function, violating docs/architecture.md golden principle #1 ("All DB access through db.py functions"). **Recommendation:** Move the bulk-archive query into `db.py` as `db.bulk_archive_delivered(shipment_ids)`. Full detail: `docs/architecture-review.md` § C, Finding "Route handler bypasses db.py with raw SQL"

bullitt added the

arch

label

2026-07-01 07:27:46 +02:00

bullitt commented

2026-07-01 08:43:34 +02:00

Author

Owner

Fixed on branch architecture-rework, commit ebcc1f8: added db.bulk_archive_delivered(user_id), moved the raw SQL from api_bulk_archive_delivered into it. Full suite: 257 passed.

Fixed on branch `architecture-rework`, commit ebcc1f8: added `db.bulk_archive_delivered(user_id)`, moved the raw SQL from `api_bulk_archive_delivered` into it. Full suite: 257 passed.

bullitt closed this issue

2026-07-01 08:44:00 +02:00

bullitt referenced this issue from a commit

2026-07-01 09:15:22 +02:00

refactor: move bulk-archive raw SQL from main.py into db.py (fixes #56)